You're correct in that anything converted to Roth is treated as ordinary income in the year of the conversion. (If you have basis in your traditional IRA, which is unusual and you should know if you do, then a pro rata amount of the conversion would not be taxable.)
The income from the conversion adds to AGI, and therefore impacts anything that is calculated from AGI. This typically includes ACA subsidies, state income taxes, and FAFSA SAI effects. You probably make too much for ACA subsidies, you already know about state income taxes, and you are too young (probably) for FAFSA for your kids.
The general strategy is to convert in "lower" income years to use up "relatively low" tax brackets. The thing you have to take a guess at is whether this year is a "lower" income year for you and you have access to "relatively low" brackets to fill up.
Things that determine "lower" include:
1. If one of you dies much earlier than the other, then the survivor will be likely in a "higher" bracket because the income will be mostly the same but the survivor will be filing Single instead of MFJ.
2. TCJA expiration in 2026. Unless Congress acts, tax brackets are getting smaller and rates are increasing on 1/1/2026.
3. Any future income streams like SS benefits or RMDs will make income "higher" later. Although with your apparently short high income career, your SS benefits are probably not that big. Maybe your spouse's SS will be, though?
4. If you're giving significantly to charity, you can do this in a tax efficient manner with QCDs at age 70.5 or leaving part of your traditional IRA to charity. In these cases, the tax rate on those donations is 0%, so that would qualify as "lower".
5. You didn't mention NIIT, but you may be subject to it at some point. Probably most online federal income tax calculators ignore NIIT, which would be a ~3.8% additional federal tax on part of your income.
6. You might read up on IRMAA as well. That will probably impact you at age 65.
7. Some people save some of their traditional IRA for long term care. The idea being that if you have high medical expenses, you can deduct those on Schedule A and effectively make those withdrawals tax free. This mostly works - there is a bit of a loss in that you get the standard deduction anyway, and medical expenses have to exceed 7.5% of AGI to be deductible.
8. There is sort of a philosophical decision to be made. Some people prefer to postpone taxes as much as possible, perhaps figuring that they'll die first, or the government will lower taxes, or there will be some loophole they can find and use, or just the pain of paying will be later. Some people think taxes are going higher and would rather "lock in" their tax bill now.
What I personally do is have a spreadsheet built to approximately calculate my federal income tax burden each year out to age 90. I then look at the highest rate that I'm likely to see in my lifetime (so I look at the maximum marginal rate between now and about age 85). I then do a pro forma tax return in December each year and then Roth convert up to whatever that maximum marginal rate will be (or a bit below). Lather rinse repeat annually.
My personal "hurdle" rate will be different than yours, but the principal is the same: shift income from higher income years to lower income years.
Oh, and you want to look at marginal rate for each dollar converted. Sometimes there are tax humps and spikes which can make Roth conversions uneconomical. The Case Study Spreadsheet by
@MDM is great for doing this kind of analysis.
Almost certainly you will find that the answer to your question is to bequeath to charity from your traditional IRA in whatever amount you decide to be charitable. And then Roth convert a portion of your traditional IRA each year up to some hurdle rate, which for you might be the top of the current 24% bracket (but could be higher or lower based on any of the above factors).
