I'm on the keep it side, in part because of the literal thousands of dollars we shaved off our house build by reusing materials my husband and father had kept, and, no doubt, in part because we have a barn to store tools and supplies (a barn, I should mention, that's roofed in 30-year old tin my father kept in his barn until a need arose).
It depends on your lifestyle and your space. Don't pay for storage, but buttons, for example, are small and easy to store. Plus they run about $4-5 for six of the things, new, plus then you've put all that into landfills and then still contributed to pollution and waste when you buy new ones.
That landfill-pollution-waste cycle applies to everything. Consider your circumstances, but I voted for saving what you can, especially since you seem to use, not hoard, based on your button ornaments.