Gold (et al.) are not good investments, and a poor choice for an apocalypse scenario (knowledge, food, medicine, guns, ammo, salt)
But they are good for the far more likely monetary/financial or political crisis.
Good in what way though? There are endless scenarios where a central government can just take gold from their citizens if they need it for some reason.
I see very very few scenarios where the private ownership of some gold will significantly improve someone's safety in an economic collapse kind of situation.
Who do you sell it to in the event of economic collapse?? How does that work???
I mean, yeah, theoretically it could be useful, but practically, I would think that a small personal collection of gold isn't likely to be a major game changer for most private middle class citizens.
There are also endless scenarios that don't involve acute apocalyptic events or total economic collapse.
Aside from nuclear war, the overwhelming majority of files that public safety works on are not apocalypse-type events with mass population destruction and absolute collapse of centralized government.
That's the stuff of great television, but shouldn't account for any significant component of anyone's risk management plan. Certainly not a significant portion of their investment planning.
There are many many varied states of ongoing emergency that everyone should be concerned about, but that guns and gold will do absolutely nothing to help with.
That said, I think there is enormous utility in acknowledging that your 'stache can only provide you with so much security, and that depending on it to keep you safe in all possible scenarios is kind of nuts.
Play smart within the system you live, and don't expect any system to magically keep you safe...nor any stockpile of anything.